Bring coverage back up to 100%#392
Merged
jakirkham merged 8 commits intozarr-developers:mainfrom Nov 7, 2022
Merged
Conversation
Since nothing is done in this case, we can just skip having it. So drop this case.
joshmoore
reviewed
Nov 7, 2022
joshmoore
reviewed
Nov 7, 2022
Member
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
One minor comment. Coverage definitely improved. 👍 (Let me know if you want help identifying the last few percentage points)
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
===========================================
+ Coverage 99.61% 100.00% +0.38%
===========================================
Files 54 53 -1
Lines 2101 2024 -77
===========================================
- Hits 2093 2024 -69
+ Misses 8 0 -8
|
Member
Author
|
Thanks all! 🙏 Merging to get this fixed. We can follow up on anything else afterwards. |
Member
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring coverage back up to 100%.
TODO: