Skip to content

Bring coverage back up to 100% #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 7, 2022
Merged

Bring coverage back up to 100% #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
029d0b1
Drop `else` case
jakirkham Nov 7, 2022
ca0ef4e
Assert `keepbits` is as expected
jakirkham Nov 7, 2022
3309f8a
Ignore `...` lines in `NDArrayLike` `Protocol`
jakirkham Nov 7, 2022
01c8968
Correct keepbits assertion
joshmoore Nov 7, 2022
59fa03a
Revert change in `bitround`
jakirkham Nov 7, 2022
cf6b710
Merge zarr-developers/main into jakirkham/fix_cov
jakirkham Nov 7, 2022
8b09bea
Include Martin's contribution in release notes
jakirkham Nov 7, 2022
9130735
Ignore missing codec from registry case
jakirkham Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ Maintenance
* Update ReadTheDocs.
By :user:`John Kirkham <jakirkham>`, :issue:`383`.

* Bring coverage back up to 100%.
By :user:`John Kirkham <jakirkham>` and :user:`Martin Durant <martindurant>`,
:issue:`392` and :issue:`393`.

* Collect coverage on all OSes & enable Codecov.
By :user:`John Kirkham <jakirkham>`, :issue:`386`, :issue:`388`,
:issue:`390`, :issue:`391`.
Expand Down
12 changes: 6 additions & 6 deletions numcodecs/ndarray_like.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,22 @@ class NDArrayLike(Protocol, metaclass=_CachedProtocolMeta):
flags: FlagsObj

def __len__(self) -> int:
...
... # pragma: no cover

def __getitem__(self, key) -> Any:
...
... # pragma: no cover

def __setitem__(self, key, value):
...
... # pragma: no cover

def tobytes(self, order: Optional[str] = ...) -> bytes:
...
... # pragma: no cover

def reshape(self, *shape: int, order: str = ...) -> "NDArrayLike":
...
... # pragma: no cover

def view(self, dtype: DType = ...) -> "NDArrayLike":
...
... # pragma: no cover


def is_ndarray_like(obj: object) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion numcodecs/tests/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ def test_all_classes_registered():
# remove `None``
missing.remove(None)
if missing:
raise Exception(f"these codecs are missing: {missing}")
raise Exception(f"these codecs are missing: {missing}") # pragma: no cover
2 changes: 0 additions & 2 deletions numcodecs/zfpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ def __init__(
self.compression_kwargs = {"rate": rate}
elif mode == _zfpy.mode_fixed_precision:
self.compression_kwargs = {"precision": precision}
else:
pass

self.tolerance = tolerance
self.rate = rate
Expand Down