Skip to content

Unnecessary None provided as default #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Unnecessary None provided as default #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/release.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Fix
Maintenance
~~~~~~~~~~~

* Remove unnecessary None argument to .get(), it is the default value.
By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>`, :issue:`395`.

* Apply refurb suggestions.
By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>`, :issue:`372`.

Expand Down
2 changes: 1 addition & 1 deletion numcodecs/ndarray_like.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class _CachedProtocolMeta(Protocol.__class__):

def __instancecheck__(self, instance):
key = (self, instance.__class__)
ret = self._instancecheck_cache.get(key, None)
ret = self._instancecheck_cache.get(key)
if ret is None:
ret = super().__instancecheck__(instance)
self._instancecheck_cache[key] = ret
Expand Down