Skip to content

Refresh and rework requirements #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2018
Merged

Refresh and rework requirements #94

merged 4 commits into from
Nov 7, 2018

Conversation

@alimanfoo
Copy link
Member

@alimanfoo alimanfoo commented Nov 6, 2018

This PR reworks the requirements files for easier maintenance:

  • All indirect dependencies have been removed from requirements files.
  • File requirements_dev.txt contains only direct requirements needed to run numcodecs, with versions pinned. This is something we would track with a bot to automatically upgrade.
  • New file requirements_test.txt contains packages needed to run tests, not pinned. I have not pinned these because otherwise I fear the churn from a bot would get too much.

TODO:

  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

alimanfoo
alimanfoo commented Nov 6, 2018
View reviewed changes
.travis.yml

install:
- pip install -U tox-travis coveralls pip setuptools wheel
- pip install -r requirements_dev.txt
Copy link
Member Author

@alimanfoo alimanfoo Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not actually needed as installation is handled within tox.

@alimanfoo alimanfoo requested a review from jakirkham November 6, 2018 16:42
@alimanfoo alimanfoo mentioned this pull request Nov 6, 2018
Closed
jakirkham
jakirkham reviewed Nov 6, 2018
View reviewed changes
numcodecs/tests/common.py

from numcodecs.compat import buffer_tobytes, ndarray_from_buffer
from numcodecs import * # flake8: noqa
from numcodecs.registry import get_codec
Copy link
Member

@jakirkham jakirkham Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this might be related to the CI failure. Not sure though.

Copy link
Member Author

@alimanfoo alimanfoo Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, my bad. Should be fixed now.

@jakirkham
Copy link
Member

jakirkham commented Nov 6, 2018

Generally seems reasonable to me.

@alimanfoo alimanfoo force-pushed the upgrade-requirements-alimanfoo-20181106 branch from 595d002 to 7399d9d Compare November 6, 2018 23:15
@alimanfoo alimanfoo changed the title WIP Refresh and rework requirements Refresh and rework requirements Nov 6, 2018
@alimanfoo
Copy link
Member Author

alimanfoo commented Nov 6, 2018

Thanks @jakirkham. I'll wait for appveyor to pass then merge and setup PyUP if no objections.

@jakirkham
Copy link
Member

jakirkham commented Nov 6, 2018

As long as it's green, I'm happy. 😄

@alimanfoo alimanfoo merged commit 930b9d3 into zarr-developers:master Nov 7, 2018
@alimanfoo alimanfoo added this to the 0.6.0 milestone Nov 7, 2018
@alimanfoo alimanfoo deleted the upgrade-requirements-alimanfoo-20181106 branch November 7, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@alimanfoo @jakirkham