Skip to content

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 6, 2018

Fixes the GitHub issue URLs in the changelog. Also updates the instructions.

There is one old URL remaining in the changelog related to Coveralls (when it was setup). Not sure if that is worth changing or not.

Edit: Skipped CI as it shouldn't matter here. Built the docs locally to verify the issue links worked correctly.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham jakirkham requested a review from alimanfoo November 6, 2018 16:46
Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks.

@alimanfoo alimanfoo merged commit 950b0da into zarr-developers:master Nov 6, 2018
@alimanfoo alimanfoo added this to the 0.6.0 milestone Nov 6, 2018
@jakirkham jakirkham deleted the fix_old_origin_urls branch November 6, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants