Skip to content

Adds a no cover line for the ncores fallback #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

Adds a no cover line for the ncores fallback #96

merged 1 commit into from
Nov 6, 2018

Conversation

@jakirkham
Copy link
Member

@jakirkham jakirkham commented Nov 6, 2018

Follow-up to PR ( #93 )

Adds a no cover for the exception case since cpu_count always works for us on CI.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@jakirkham jakirkham mentioned this pull request Nov 6, 2018
Merged
@jakirkham jakirkham requested a review from alimanfoo November 6, 2018 17:44
@jakirkham jakirkham mentioned this pull request Nov 6, 2018
Merged
8 tasks
@jakirkham jakirkham merged commit 6e3e100 into zarr-developers:master Nov 6, 2018
@jakirkham jakirkham deleted the no_cover_ncores_fallback branch November 6, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakirkham @alimanfoo