Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Oct 20, 2025

A simple change that treats "bytes" as an alias for "variable_length_bytes". This will address part of the problems revealed in #3513

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Oct 20, 2025
@d-v-b d-v-b requested a review from rabernat October 20, 2025 12:15
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.86%. Comparing base (7fe95b5) to head (5d6b515).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3532   +/-   ##
=======================================
  Coverage   61.86%   61.86%           
=======================================
  Files          85       85           
  Lines       10112    10112           
=======================================
  Hits         6256     6256           
  Misses       3856     3856           
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/bytes.py 53.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Oct 20, 2025
@d-v-b d-v-b requested a review from a team October 21, 2025 20:51
@d-v-b
Copy link
Contributor Author

d-v-b commented Oct 22, 2025

@zarr-developers/python-core-devs could someone review this? It would be nice to have this merged today in time for a release.

@d-v-b d-v-b merged commit e3ee591 into zarr-developers:main Oct 22, 2025
32 checks passed
@d-v-b d-v-b deleted the fix/bytes-alias branch October 22, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants