fix: minor correctness and hygiene fixes from the sync-pipeline audit - #4205
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
+ Coverage 93.91% 93.92% +0.01%
==========================================
Files 91 91
Lines 12723 12744 +21
==========================================
+ Hits 11949 11970 +21
Misses 774 774
🚀 New features to boost your workflow:
|
d-v-b
force-pushed
the
fix/perf-pr-minor-cleanups
branch
from
July 29, 2026 14:32
ef0c196 to
6d30b53
Compare
d-v-b
marked this pull request as ready for review
July 29, 2026 14:38
- Codec construction warnings (e.g. sharding's "disables partial reads") fired twice per array open, and on every decode/encode through the fused pipeline's async fallback. Re-constructions of an already-validated codec chain now go through codecs_from_list_unchecked, which validates structure without repeating first-construction advisory warnings; each warning fires exactly once per open under both pipelines. - concurrent_iter returned a lazy generator while its docstring promised eagerly scheduled tasks; it now materializes the task list so awaiting one at a time cannot serialize the batch. - A garbage codec_pipeline.max_workers value (e.g. from the environment) raised ValueError mid-read; it now warns and falls back to the default, consistent with tolerant handling of config input. - The as-completed pipeline helpers abandoned in-flight tasks when one failed, leaving stray background writes and "Task exception was never retrieved" warnings; failures now cancel and drain outstanding tasks. - Benchmarks: seed the data generator for reproducibility; fix a copy-pasted docstring. - Remove dead commented-out test blocks referencing the removed set_range API. Assisted-by: ClaudeCode:claude-sonnet-5
d-v-b
force-pushed
the
fix/perf-pr-minor-cleanups
branch
from
July 30, 2026 07:24
6d30b53 to
cdb0e00
Compare
Contributor
Author
|
these are internal changes that improve the usability of the new fusedcodecpipeline, so I will self-merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A variety of fixes exposed after claude did an audit of #3885
🤖 AI text below 🤖
Assisted-by: ClaudeCode:claude-sonnet-5
Based on this claude-authored PR: d-v-b#259
Author attestation
TODO
docs/user-guide/*.mdchanges/