Remove the remaining ZenHub references - #88
Open
CodeMongerrr wants to merge 1 commit into
Open
Conversation
ZenHub support was removed from the Python, but references survived in the shell scripts, the README and .gitignore. gen-schema.sh still generated a zenhub_schema.py that nothing imports, and gen-dag.sh still passed SHOW_EPICS and ZENHUB_TOKEN, neither of which is read any more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#87 took ZenHub out of the Python, but a few references survived in the shell scripts, the README and
.gitignore. This clears out what was left.What was still there:
gen-schema.shstill introspected the ZenHub GraphQL API and ransgqlc-codegento producezenhub_schema.py. Nothing imports that module any more, so it was generating a file no code reads — and it needs aZENHUB_TOKENfile to get that far.gen-dag.shstill passedSHOW_EPICS=trueandZENHUB_TOKENtozcash-issue-dag.py. Neither is read any more — the script only looks atGITHUB_TOKEN,DAG_VIEW,TERMINATE_AT,ONLY_INCLUDE,INCLUDE_FINISHED,PRUNE_FINISHEDandSHOW_MILESTONES. Without aZENHUB_TOKENfile sitting in the working directory it also printscat: ZENHUB_TOKEN: No such file or directoryonce per view. It's harmless — the assignment doesn't tripset -e, so the loop still finishes — but it's a confusing thing to hit when you're setting the repo up for the first time.README.mdasked for two token files and documentedSHOW_EPICS, so a new contributor would go off and create a ZenHub token they don't actually need..gitignorestill ignoredzenhub_schema.json,zenhub_schema.pyandZENHUB_TOKEN.helpers/github.pyabout "graph nodes from ZenHub" — those come from GitHub now.I checked that nothing reads
SHOW_EPICSorZENHUB_TOKENbefore pulling them out, andgrep -ri zenhubnow comes back empty across the tree.bash -npasses on both scripts.One thing I noticed but deliberately left out of this PR, happy to send it separately if it'd be useful: the README lists seven
DAG_VIEWvalues, butREPO_SETSinhelpers/github.pycurrently has fourteen —zallet,ecc,zf-frost,zf-devops,zcashd-deprecation,sprout-deprecationandtransparent-deprecationdon't get a mention.TERMINATE_AT,ONLY_INCLUDEandPRUNE_FINISHEDaren't documented either. Felt like a separate change from the ZenHub cleanup.