fix(worker): route mock agent diagnostics through logger#12
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the worker’s mock.agent debug component to route its diagnostic output through the component execution logger (context.logger.info) rather than writing directly to console.log, and adds a regression test to prevent reintroducing console-based diagnostics. This aligns the component’s diagnostics with the worker’s execution-log collection path while reducing default terminal noise during local test/pre-push runs.
Changes:
- Replaced direct
console.logdiagnostics inmock.agentwithcontext.logger.infovia a smalllogDiagnostic()helper. - Added a unit test asserting the component does not call
console.logand that diagnostics flow through the provided execution logger.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
worker/src/components/dev/mock-agent.ts |
Routes mock-agent diagnostics through context.logger.info instead of console.log. |
worker/src/components/dev/__tests__/mock-agent.test.ts |
Adds a regression test that fails if diagnostics are written via console.log. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mock.agentdiagnostic messages throughcontext.logger.infoinstead of rawconsole.logconsole.logVerification
bun test worker/src/components/dev/__tests__/mock-agent.test.tsfailed with 3console.logcallsbun test worker/src/components/dev/__tests__/mock-agent.test.tsbun test worker/src/components/devgit diff --checkbun run lintbun run typecheckbun run testbunx tsc --build worker --force && bun run typecheckafter full test cleanupgit push -u origin codex/quiet-mock-agent-logspre-push hook