Clean up Knip dead-code baseline#2
Merged
Merged
Conversation
Signed-off-by: zebbern <185730623+zebbern@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR cleans up the Knip dead-code baseline by making Knip aware of workspace test entry points (instead of globally ignoring tests), and by removing unused frontend auth code plus stale one-off debug/helper scripts. It also adds explicit package scripts so E2E setup and version syncing are runnable via stable bun run <script> entry points.
Changes:
- Updated
knip.jsonto include frontend (and other workspace) test files/entry points and removed blanket test-file ignores. - Removed unused
usePermissionshook + its tests, and deleted several stale debug/helper scripts. - Added
test:e2e:setupandrelease:sync-versionsscripts, and updated docs / local E2E helper to use them.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/view-debug-logs.ts | Deleted stale debug log viewing helper. |
| scripts/test-loki-range.ts | Deleted one-off Loki range test helper. |
| scripts/e2e-local-test.sh | Switched env setup call to the new test:e2e:setup package script. |
| scripts/discover-aws-mcp-tools.ts | Deleted stale AWS MCP discovery helper script. |
| scripts/capture-run-stream.ts | Deleted stale SSE stream capture helper script. |
| package.json | Added test:e2e:setup and release:sync-versions script entry points. |
| knip.json | Included workspace test files/entry points; removed blanket test ignore patterns; added frontend workspace config. |
| frontend/src/components/auth/usePermissions.ts | Removed unused permissions hook. |
| frontend/src/components/auth/tests/usePermissions.test.tsx | Removed tests for deleted usePermissions hook. |
| docs/development/release-process.mdx | Updated release docs to use bun run release:sync-versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
28
to
30
| echo "Setting up environment..." | ||
| bun run e2e-tests/scripts/setup-e2e-env.ts || { | ||
| bun run test:e2e:setup || { | ||
| echo "❌ Setup cancelled" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan