Add EmmyLua_LS support - #60
Open
notpeter wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for emmylua_ls using the same pattern as the Zed Ruby extension to support multiple LSPs (distinct IDs, settings, paths, etc). Only LuaLS will be enabled by default. While making these changes I also improved LSP Symbol and Completion handling for both the existing and new language servers.
emmylua_lsin addition tolua-language-serverworktree.which; Zed auto-download from GitHub releases (both LSPs)FIELDcompletions (both LSPs)Prior to shipping an extension in the Zed extension store with this code, a companion PR to the Zed repo with new default settings is needed so Zed will automatically prefer LuaLS and disable EmmyLuaLS by default (merge, cherry-pick to preview; wait a week to minimize impact):