Fix test debug locator - #44
Open
lejmr wants to merge 2 commits into
Open
Conversation
`strip_prefix("-femit-bin=")` already returns the bare path, so the following
`split("=").nth(1)` only produced a value when the path itself contained a `=`.
Everywhere else it returned `None`, so the locator failed with "None of the
locators for task `zig test --test-no-exec` completed successfully" and
debugging a test was impossible.
The build task is spawned directly rather than through a shell, so the quotes wrapping $ZED_CUSTOM_ZIG_TEST_NAME in the zig-test task template end up inside the filter string. `zig test --test-filter "'demo'"` reports "All 0 tests passed", so the debug session launched a binary containing no tests and exited immediately. Each argument is already a single argv element, so no quoting is needed.
|
We require contributors to sign our Contributor License Agreement, and we don't have @lejmr on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes broken breakpoint in debug mode.. the test before only ran through without stopping on breakpoint.