Add integrated terminal bell + settings - #53752
Merged
probably-neb merged 9 commits intoApr 23, 2026
Merged
Conversation
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This should allow for potential future enhancements like visual bell, custom sounds, etc. if that becomes desirable (e.g. like ghostty)
cla-bot
Bot
added
the
cla-signed
zed-codeowner-coordinator
Bot
requested review from
a team,
danilo-leal and
probably-neb
and removed request for
a team
April 12, 2026 22:26
probably-neb
requested changes
Apr 13, 2026
| "show_count_badge": false, | ||
| "bell": { | ||
| // Whether to invoke the OS-default alert sound when the terminal bell (BEL character) is printed. | ||
| "system": true, |
Collaborator
There was a problem hiding this comment.
This settings structure doesn't really make sense as it is.
If we were to add different sound options the settings would look like
"bell": {
"system": false,
"other-sound": true,
}This should be
"bell": "off" // default
"bell": "system" // use system alert soundor similar
Contributor
Author
There was a problem hiding this comment.
That's fair, I was thinking a struct/object made sense to allow for the possibility of visual bells or other indicators (like desktop notifications, toasts, whatever), as suggested in #47531 (comment)
Also was looking at VSCode for inspiration here, they have an accessibility setting for announcing the terminal bell (probably via some text-to-speech or something): https://github.com/microsoft/vscode/blob/1faf9f4d1bab92b16b16cc6306f828a8f32567bf/src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts#L497-L510
What do you think about something like this?
"bell": {
"audio": "system", // or "off", etc.
// possible future enhancements:
"visual": "off",
"notification": "on",
"announce": "off"
}
Collaborator
There was a problem hiding this comment.
Interesting. I think we should keep it simple, with no nested object for now. It's fairly easy to do a settings migration and add the extra structure if we ever add more capabilities. Until then it's just extra typing in the settings JSON, making the setting less discoverable.
Contributor
probably-neb
approved these changes
Apr 23, 2026
injust
reviewed
Apr 23, 2026
| pub show_count_badge: Option<bool>, | ||
| /// What to do when the `BEL` character (`\a`) is printed to terminal. | ||
| /// | ||
| /// Default: "system" |
Contributor
There was a problem hiding this comment.
This was missed when changing the default.
kathbigra
pushed a commit
to kathbigra/zed
that referenced
this pull request
May 10, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] ~Unsafe blocks (if any) have justifying comments~ - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Followup to zed-industries#47531 to use the gpui feature in Zed. This just plumbs the "system bell" feature into the terminal, behind a new setting (enabled by default, like most other terminal applications). Closes zed-industries#5303 Relates to zed-industries#40826 (comment) Release Notes: - Added audible BEL to Terminal; can be enabled by setting `terminal.bell` to `"system"`. --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Ben Kunkle <Ben.kunkle@gmail.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] ~Unsafe blocks (if any) have justifying comments~ - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Followup to zed-industries#47531 to use the gpui feature in Zed. This just plumbs the "system bell" feature into the terminal, behind a new setting (enabled by default, like most other terminal applications). Closes zed-industries#5303 Relates to zed-industries#40826 (comment) Release Notes: - Added audible BEL to Terminal; can be enabled by setting `terminal.bell` to `"system"`. --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Ben Kunkle <Ben.kunkle@gmail.com>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] ~Unsafe blocks (if any) have justifying comments~ - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Followup to zed-industries#47531 to use the gpui feature in Zed. This just plumbs the "system bell" feature into the terminal, behind a new setting (enabled by default, like most other terminal applications). Closes zed-industries#5303 Relates to zed-industries#40826 (comment) Release Notes: - Added audible BEL to Terminal; can be enabled by setting `terminal.bell` to `"system"`. --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Ben Kunkle <Ben.kunkle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Unsafe blocks (if any) have justifying commentsFollowup to #47531 to use the gpui feature in Zed. This just plumbs the "system bell" feature into the terminal, behind a new setting (enabled by default, like most other terminal applications).
Closes #5303
Relates to #40826 (comment)
Release Notes:
terminal.bellto"system".