gpui: Add bare bones benchmark framework - #58191
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
maxdeviant
changed the title
MartinYe1234
self-requested a review
June 1, 2026 22:19
MartinYe1234
approved these changes
Jun 1, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
### Summary Adds the first pass at `#[gpui::bench]`, backed by Criterion, with a new `BenchAppContext` for GPUI benchmarks. This ports one editor benchmark to the new setup while keeping the existing Criterion render benchmarks in place. ### Follow Ups I eventually want to improve this framework to create custom tracy profiles that includes additional information such as - notify count - entity.update count and time - event emitted and time for that I also want to use this to create custom measurements so benches can be used for - Frames dropped - foreground thread time - Render time - etc This PR is a very small proof of initial concept and I'll continue to build this infrastructure out so Zed and other gpui apps can become a lot more resilient to dropping frames and hangs. Plus it will make improving performance a lot easier as well in the future. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
### Summary Adds the first pass at `#[gpui::bench]`, backed by Criterion, with a new `BenchAppContext` for GPUI benchmarks. This ports one editor benchmark to the new setup while keeping the existing Criterion render benchmarks in place. ### Follow Ups I eventually want to improve this framework to create custom tracy profiles that includes additional information such as - notify count - entity.update count and time - event emitted and time for that I also want to use this to create custom measurements so benches can be used for - Frames dropped - foreground thread time - Render time - etc This PR is a very small proof of initial concept and I'll continue to build this infrastructure out so Zed and other gpui apps can become a lot more resilient to dropping frames and hangs. Plus it will make improving performance a lot easier as well in the future. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
### Summary Adds the first pass at `#[gpui::bench]`, backed by Criterion, with a new `BenchAppContext` for GPUI benchmarks. This ports one editor benchmark to the new setup while keeping the existing Criterion render benchmarks in place. ### Follow Ups I eventually want to improve this framework to create custom tracy profiles that includes additional information such as - notify count - entity.update count and time - event emitted and time for that I also want to use this to create custom measurements so benches can be used for - Frames dropped - foreground thread time - Render time - etc This PR is a very small proof of initial concept and I'll continue to build this infrastructure out so Zed and other gpui apps can become a lot more resilient to dropping frames and hangs. Plus it will make improving performance a lot easier as well in the future. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first pass at
#[gpui::bench], backed by Criterion, with a newBenchAppContextfor GPUI benchmarks.This ports one editor benchmark to the new setup while keeping the existing Criterion render benchmarks in place.
Follow Ups
I eventually want to improve this framework to create custom tracy profiles that includes additional information such as
I also want to use this to create custom measurements so benches can be used for
This PR is a very small proof of initial concept and I'll continue to build this infrastructure out so Zed and other gpui apps can become a lot more resilient to dropping frames and hangs. Plus it will make improving performance a lot easier as well in the future.
Self-Review Checklist:
Release Notes: