Fix traffic light padding on macOS SDK 26+ builds - #58245
Merged
Anthony-Eid merged 2 commits intoJun 2, 2026
Conversation
cla-bot
Bot
added
the
cla-signed
Anthony-Eid
approved these changes
Jun 2, 2026
dinocosta
added
the
platform:macOS
albertbogusz
changed the title
dandv
pushed a commit
to dandv/zed
that referenced
this pull request
Jun 3, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] ~~Unsafe blocks (if any) have justifying comments~~ (N/A) - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Corrects the value used for traffic light clearance/padding when building with the macOS 26 SDK (or later). This was originally fixed in zed-industries#45351 but regressed in zed-industries#48800 where `TRAFFIC_LIGHT_PADDING` was moved to `ui/src/utils/constants.rs` but the local `build.rs` in `title_bar` did not apply to the `ui` crate. Release Notes: - N/A
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] ~~Unsafe blocks (if any) have justifying comments~~ (N/A) - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Corrects the value used for traffic light clearance/padding when building with the macOS 26 SDK (or later). This was originally fixed in zed-industries#45351 but regressed in zed-industries#48800 where `TRAFFIC_LIGHT_PADDING` was moved to `ui/src/utils/constants.rs` but the local `build.rs` in `title_bar` did not apply to the `ui` crate. Release Notes: - N/A
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] ~~Unsafe blocks (if any) have justifying comments~~ (N/A) - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Corrects the value used for traffic light clearance/padding when building with the macOS 26 SDK (or later). This was originally fixed in zed-industries#45351 but regressed in zed-industries#48800 where `TRAFFIC_LIGHT_PADDING` was moved to `ui/src/utils/constants.rs` but the local `build.rs` in `title_bar` did not apply to the `ui` crate. Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] ~~Unsafe blocks (if any) have justifying comments~~ (N/A) - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Corrects the value used for traffic light clearance/padding when building with the macOS 26 SDK (or later). This was originally fixed in zed-industries#45351 but regressed in zed-industries#48800 where `TRAFFIC_LIGHT_PADDING` was moved to `ui/src/utils/constants.rs` but the local `build.rs` in `title_bar` did not apply to the `ui` crate. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Review Checklist:
Unsafe blocks (if any) have justifying comments(N/A)Corrects the value used for traffic light clearance/padding when building with the macOS 26 SDK (or later). This was originally fixed in #45351 but regressed in #48800 where
TRAFFIC_LIGHT_PADDINGwas moved toui/src/utils/constants.rsbut the localbuild.rsintitle_bardid not apply to theuicrate.Release Notes: