Fix hang detection crash when foreground stats are missing - #58464
Merged
Anthony-Eid merged 3 commits intoJun 3, 2026
Merged
Conversation
Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
maxbrunsfeld
approved these changes
Jun 3, 2026
Co-authored-by: Yara <git@yara.blue>
Anthony-Eid
enabled auto-merge
June 3, 2026 21:49
yara-blue
approved these changes
Jun 3, 2026
…in-all-statistics
Anthony-Eid
deleted the
anthony/fr-58-zed-8xd-main-thread-should-be-in-all-statistics
branch
June 3, 2026 22:01
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…tries#58464) Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data. cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes FR-58 Release Notes: - Fixed a crash in hang detection when foreground thread statistics were missing. --------- Co-authored-by: Yara <git@yara.blue>
Contributor
Author
|
/cherry-pick preview |
Merged
5 tasks
zed-zippy Bot
added a commit
that referenced
this pull request
Jun 8, 2026
…cherry-pick to preview) (#58850) Cherry-pick of #58464 to preview ---- Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data. cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes FR-58 Release Notes: - Fixed a crash in hang detection when foreground thread statistics were missing. --------- Co-authored-by: Yara <git@yara.blue> Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-authored-by: Yara <git@yara.blue>
This was referenced Jun 10, 2026
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…tries#58464) Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data. cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes FR-58 Release Notes: - Fixed a crash in hang detection when foreground thread statistics were missing. --------- Co-authored-by: Yara <git@yara.blue>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…tries#58464) (cherry-pick to preview) (zed-industries#58850) Cherry-pick of zed-industries#58464 to preview ---- Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data. cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes FR-58 Release Notes: - Fixed a crash in hang detection when foreground thread statistics were missing. --------- Co-authored-by: Yara <git@yara.blue> Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Co-authored-by: Yara <git@yara.blue>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…tries#58464) Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data. cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes FR-58 Release Notes: - Fixed a crash in hang detection when foreground thread statistics were missing. --------- Co-authored-by: Yara <git@yara.blue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the foreground thread with the GPUI profiler before starting hang detection, so foreground task statistics are available when the hang detection thread samples profiler data.
cc: @yara-blue I choose to leave the expect statements because it seems like an invariant that we should uphold. Let me know if you would rather have early returns and telemetry if they're hit
Self-Review Checklist:
Closes FR-58
Release Notes: