terminal: Respect word boundaries after tree branches - #62076
Open
macayu17 wants to merge 1 commit into
Open
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @macayu17 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes terminal double-click semantic selection so that service names following systemctl-style tree branch prefixes (e.g. └─) are selected without including the branch glyphs, improving copy/paste usability in the terminal.
Changes:
- Extend Alacritty terminal config
semantic_escape_charsto treat the box-drawing horizontal bar─as a semantic word boundary (for both PTY and display-only terminals). - Add a regression test asserting semantic selection on
└─zms-demo.targetreturns onlyzms-demo.target.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #61767.
Double-clicking a service name after a
systemctltree branch also selects the└─prefix.Solution
Add
─to Alacritty's semantic escape characters for both PTY and display-only terminals. The regression test checks that selecting└─zms-demo.targetreturns onlyzms-demo.target.Testing
cargo fmt --all -- --checkgit diff --checksemantic_selection_stops_at_tree_branchThe regression test could not run locally because this Windows environment does not have MSVC's
link.exe. It can be run with:cargo test -p terminal semantic_selection_stops_at_tree_branchSelf-Review Checklist:
Release Notes: