Update Faraday gem #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/support/client_helpers.rb
Outdated
| end | ||
|
|
||
| def client_with_basic_retry | ||
| @client_with_basic_retry ||= BaseCRM::Client.new(access_token: access_token, base_url: base_url, max_retry: 1, retry_statuses: [200]) |
There was a problem hiding this comment.
This setup is misleading, why retrying on HTTP 200? I know this is just for test, but someone may explore possible options by looking at specs.
Contributor
Author
There was a problem hiding this comment.
To be double sure? 🤣
But to be serious I got your point this may push people to actually retry on 200. Changed.
struniu
force-pushed
the
strus/faraday-update
branch
from
ffd650f to
d3fb75c
Compare
struniu
force-pushed
the
strus/faraday-update
branch
from
d3fb75c to
23629df
Compare
dawidpawliszko
approved these changes
Oct 27, 2021
This was referenced Oct 27, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Improvements
max_retryandretry_statusesto specify no. of retries on failed request and statuses to retry.May break compatibility because of the new Faraday