Solution to timestamp default issue #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathildemouw
changed the title
|
Hey @mathildemouw sorry we missed this. I did merge the other pull request but it had some other stuff as well. If you pull in all other changes I'll merge this as well. I like this approach. |
mathildemouw
force-pushed
the
master
branch
from
5f0ba52 to
0eb41f6
Compare
|
@MrTravisB I believe this fork is all caught up with master now. The tests are still passing so my changes to the timestamp default behavior should be good to merge! |
MrTravisB
added a commit
that referenced
this pull request
Oct 5, 2015
Solution to timestamp default issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see that someone has already sort of fixed this in the last pull request, but I figured I would make a pull request in case you were interested in the solution I came up with.
We ran into a problem when we updated outbound where our emails stopped sending because we had been giving #track two arguments. The new #track with four arguments set our second argument equal to timestamp (#track's fourth arg,but the second argument with no defualt value). We figured out this breakage could be solved by giving #track's timestamp argument a default value.