Ignore invalid message timestamps #482
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-pang
reviewed
Nov 10, 2017
lib/kafka/protocol/message.rb
Outdated
| when 1 | ||
| timestamp = message_decoder.int64 | ||
|
|
||
| # If the timestamp is set to zero (start of UNIX epoch) there's clearly |
Contributor
There was a problem hiding this comment.
@dasch FYI that this can happen if you do an in place upgrade from 0.9.X to 0.10.X or onwards - old messages get zerod out (iirc)
Contributor
Author
There was a problem hiding this comment.
Ah! I'll fix the comment.
dasch
force-pushed
the
dasch/fix-zero-timestamp
branch
from
7c441c2 to
c3951ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently Kafka will set the timestamp to zero when migrating pre-0.10 messages.