Skip to content

Ignore invalid message timestamps #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Ignore invalid message timestamps #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/kafka/protocol/message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ def self.decode(decoder)
timestamp = nil
when 1
timestamp = message_decoder.int64

# If the timestamp is set to zero, it's because the message has been upgraded
# from the Kafka 0.9 disk format to the Kafka 0.10 format. The former didn't
# have a timestamp attribute, so we'll just set the timestamp to nil.
timestamp = nil if timestamp.zero?
else
raise Kafka::Error, "Invalid magic byte: #{magic_byte}"
end
Expand Down