Align buffer overflow erros with sync producer

[michaelsauter]

Now both producer emit buffer overflow with a message for consistency.

I investigated some buffer overflow issues on production, and first thought that the issue was to do with the max_buffer_size and max_buffer_bytesize settings. But the error did not include information which limit we had reached. I planned on adding a message to the exception which limit was reached, then realized that the synchronous producer already did this. Only then did I discover the max_queue_size setting and noticed that BufferOverflow was raised without a message if that limit was reached. I found the corresponding error message in the logs, so now I know that this was the problem, but I think it would be good to have both error cases handled in the same way.

[dasch]

Looks good!

[dasch]

I'd like to keep the log statement.

[michaelsauter]

I removed it because the sync producer doesn't have it either, and the exception already has the message. If you want exception AND logging, then I suggest we add the logging to the sync producer as well for consistency. Should I do that?

[dasch]

Good point. It’s okay to leave out the log message.

…

On Fri, 17 Nov 2017 at 17.23, Michael Sauter ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/kafka/async_producer.rb <#489 (comment)>: > @instrumenter.instrument("buffer_overflow.async_producer", { topic: topic, }) - @logger.error "Cannot produce message to #{topic}, max queue size ***@***.***_queue_size}) reached" I removed it because the sync producer doesn't have it either, and the exception already has the message. If you want exception AND logging, and I suggest we add the logging to the sync producer as well for consistency. Should I do that? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#489 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAYz39x-hU0nViHhOWpywLSF4ATG0ozks5s3bLOgaJpZM4QhwbJ> .

[dasch]

Thanks!