Skip to content

Conversation

@michaelsauter
Copy link
Contributor

Okay, this is a start. Not sure if this is the best place to do this. Also, I did not add the same instrumentation for each_batch as it would just duplicate start_process_batch.consumer. However, for consistency it might make sense to add it?

Let me know what you think and I'll adapt as necessary.

@michaelsauter
Copy link
Contributor Author

Hmm, tests failed but it looks unrelated. I ran spec/consumer_spec.rb locally and it passed.

@dasch
Copy link
Contributor

dasch commented Dec 11, 2017

Thanks!

@dasch dasch merged commit 9cef360 into zendesk:master Dec 11, 2017
@michaelsauter michaelsauter deleted the feature/fetch-batch-instrumentation branch December 11, 2017 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants