Skip to content

Extract ApiInfo#version_supported? #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Extract ApiInfo#version_supported? #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kafka/cluster.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def supports_api?(api_key, version = nil)
elsif version.nil?
return true
else
return (info.min_version..info.max_version).include?(version)
return info.version_supported?(version)
end
end

Expand Down
4 changes: 4 additions & 0 deletions lib/kafka/protocol/api_versions_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ def api_name
Protocol.api_name(api_key)
end

def version_supported?(version)
(min_version..max_version).include?(version)
end

def to_s
"#{api_name}=#{min_version}..#{max_version}"
end
Expand Down