Skip to content

fix: dedicated 404 error handling and improved error messages for connectors delete command#354

Merged
saikambaiyyagari merged 1 commit into
masterfrom
minor-fix-messages
Apr 17, 2026
Merged

fix: dedicated 404 error handling and improved error messages for connectors delete command#354
saikambaiyyagari merged 1 commit into
masterfrom
minor-fix-messages

Conversation

@saikambaiyyagari
Copy link
Copy Markdown
Contributor

@saikambaiyyagari saikambaiyyagari commented Apr 17, 2026

Change:

zcli connectors:delete command: adds a dedicated 404 branch that surfaces a clear, user-facing message ("Connector '...' not found. It may have already been deleted or does not exist.")

Description

103fb63 fix: dedicated 404 error handling and improved error messages for connectors delete command

Detail

Checklist

  • 💂‍♂️ includes new unit and functional tests

Copilot AI review requested due to automatic review settings April 17, 2026 04:39
@saikambaiyyagari saikambaiyyagari requested a review from a team as a code owner April 17, 2026 04:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the UX of zcli connectors:delete by adding dedicated handling for HTTP 404 Not Found, surfacing a clearer “connector not found” message and validating the behavior via functional tests.

Changes:

  • Add a dedicated 404 response branch in connectors:delete to emit a user-friendly not-found message (and verbose details when --verbose is set).
  • Update the existing 404 functional test expectation to match the new message.
  • Add a new functional test verifying verbose logging behavior on 404.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/zcli-connectors/src/commands/connectors/delete.ts Adds explicit 404 handling and verbose logging for a clearer deletion failure experience.
packages/zcli-connectors/tests/functional/delete.test.ts Updates/extends functional coverage to assert the new 404 message and verbose output behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/zcli-connectors/src/commands/connectors/delete.ts Outdated
@saikambaiyyagari saikambaiyyagari merged commit 0366a0d into master Apr 17, 2026
7 checks passed
@saikambaiyyagari saikambaiyyagari deleted the minor-fix-messages branch April 17, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants