fix: dedicated 404 error handling and improved error messages for connectors delete command#354
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the UX of zcli connectors:delete by adding dedicated handling for HTTP 404 Not Found, surfacing a clearer “connector not found” message and validating the behavior via functional tests.
Changes:
- Add a dedicated
404response branch inconnectors:deleteto emit a user-friendly not-found message (and verbose details when--verboseis set). - Update the existing 404 functional test expectation to match the new message.
- Add a new functional test verifying verbose logging behavior on 404.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/zcli-connectors/src/commands/connectors/delete.ts | Adds explicit 404 handling and verbose logging for a clearer deletion failure experience. |
| packages/zcli-connectors/tests/functional/delete.test.ts | Updates/extends functional coverage to assert the new 404 message and verbose output behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nectors delete command
2640533 to
103fb63
Compare
zFlabmonsta
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change:
zcli connectors:deletecommand: adds a dedicated404branch that surfaces a clear, user-facing message ("Connector '...' not found. It may have already been deleted or does not exist.")Description
103fb63fix: dedicated 404 error handling and improved error messages for connectors delete commandDetail
Checklist