feat(themes): send style.css and script.js through themes:migrate#374
Merged
Conversation
Reads the theme's root style.css and script.js, sends them to the migration endpoint as `css` and `js`, and writes the migrated content back to the theme root after splitting them out of the templates response.
The fs.readFileSync stub matched on a literal forward-slash path, but migrate.ts uses path.join which produces backslash-separated paths on Windows. The stub returned undefined there, breaking the request payload match.
BrunoBFerreira
approved these changes
May 28, 2026
Contributor
BrunoBFerreira
left a comment
BrunoBFerreira
left a comment
There was a problem hiding this comment.
Just a nitpick.
Looks great 👍
| themePath: string, | ||
| { css, js }: { css: string; js: string } | ||
| ) { | ||
| const cssPath = `${themePath}/style.css` |
Contributor
There was a problem hiding this comment.
(nit) Maybe we should use join here to build the string, since I believe it is what we use in other places of the repo.
Matches the read side in migrate.ts and addresses a review nit. Tests follow the same pattern so they stay portable on Windows.
BrunoBFerreira
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zcli themes:migratepreviously only sent the theme's.hbstemplates to the migration endpoint, ignoring the rootstyle.cssandscript.js. That blocked any migration that needs to alter raw CSS/JS — e.g. bundlingnormalize.cssinto the theme's stylesheet.This wires both files through: read them from the theme root, send them as
cssandjskeys in the request, then split them out of the response and write the migrated content back to the theme root via a newrewriteJsAndCsshelper.