[AF-1697] Only have 1 client #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehul-Porwal
approved these changes
Aug 7, 2019
hoangtrvu
requested changes
Aug 7, 2019
| let _client | ||
| const ZAFClient = { | ||
| init: function (callback, loc) { | ||
| if (_client) return _client |
There was a problem hiding this comment.
With this change, we would always return the same client regardless of different callback or loc being passed, which doesn't look right to me. I've seen apps creating multiple clients in the past during app review process, not entirely sure about their use case but I think this would be a risky change if we suddenly remove this capability.
|
Closing this, since we don't have immediate plans do make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only have 1 client. Return the client if we already had one.
https://zendesk.atlassian.net/browse/AF-1697