Skip to content

chore: add zendesk-dev.com domain to allow for scooter #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

chore: add zendesk-dev.com domain to allow for scooter #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ function isOriginValid (origin) {
/^https:\/\/.+\.zd-dev\.com$/,
/^https:\/\/.+\.zd-master\.com$/,
/^https:\/\/.+\.zendesk-staging\.com$/,
/^https:\/\/.+\.zendesk-dev\.com$/,
Copy link
Contributor Author

@zFlabmonsta zFlabmonsta Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decrease the scope to specifc region. Currently there are 2 regions

.euc1.scooter.zendesk-dev.com
.usw2.scooter.zendesk-dev.com

and a third in apac is on its way. https://zendesk.atlassian.net/browse/PLAN-7053

Copy link
Contributor

@Shengming-Yan Shengming-Yan Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain level looks fine to me

// Zendesk Chat domains:
/^https?:\/\/.+\.zopim\.com(:\d+)?$/,
/^https:\/\/dashboard\.zopim\.org$/,
Expand Down