[AF-387][BUG] Fixes an issue where Save Hook rules aren't being respect for synchronous return #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction, if not a Promise
Contributor
|
👍 with regression test |
lib/utils.js
Outdated
| } else if (isFalsy(res)) { | ||
| promise = Promise.reject(res); | ||
| } else { | ||
| promise = new Promise(function(resolve) { |
Contributor
There was a problem hiding this comment.
Promise.resolve, if i want to be a stickler
Contributor
|
👍 |
| promise = new Promise(function(resolve) { | ||
| resolve(res); | ||
| }); | ||
| promise = Promise.resolve(res); |
Contributor
Author
There was a problem hiding this comment.
@adammw 💇 To make "the stickler" less sticky
svizzari
changed the title
|
This PR was deployed to Production Release. Reference: v2.0.1 |
|
This PR was deployed to Update Major Version. Reference: v2.0.1 |
|
This PR was deployed to Production Release. Reference: v2.0.9 |
|
This PR was deployed to Pod19-Pod24 (Release). Reference: v2.0.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
Where a Save Hook handler was returning immediately, rather than a Promise, the rules governing Save Hook return values weren't being respected.
References
JIRA: https://zendesk.atlassian.net/browse/AF-387
TODO
Add regression test04a8150 59a7ac7Risks