Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Clean benign errors#132

Merged
weierophinney merged 1 commit intozendframework:masterfrom
codisart:clean-benign-errors
May 17, 2017
Merged

Clean benign errors#132
weierophinney merged 1 commit intozendframework:masterfrom
codisart:clean-benign-errors

Conversation

@codisart
Copy link
Contributor

No description provided.

@Xerkus
Copy link
Member

Xerkus commented Mar 17, 2017

That method can be used/overriden by extending code so changing its signature will be a BC break.

It would be better to default $hostname to true and simplify following check to:

if ($local && $hostname && $length) {
    return true;
}

@codisart
Copy link
Contributor Author

codisart commented Mar 26, 2017

Thank you @Xerkus for your review. I did changes to my code.

@weierophinney weierophinney merged commit 1e92244 into zendframework:master May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
weierophinney added a commit that referenced this pull request May 17, 2017
@weierophinney
Copy link
Member

Thanks, @codisart

@codisart codisart deleted the clean-benign-errors branch February 4, 2020 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants