This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Clean benign errors#132
Merged
weierophinney merged 1 commit intozendframework:masterfrom May 17, 2017
codisart:clean-benign-errors
Merged
Clean benign errors#132weierophinney merged 1 commit intozendframework:masterfrom codisart:clean-benign-errors
weierophinney merged 1 commit intozendframework:masterfrom
codisart:clean-benign-errors
Conversation
Member
|
That method can be used/overriden by extending code so changing its signature will be a BC break. It would be better to default |
Contributor
Author
|
Thank you @Xerkus for your review. I did changes to my code. |
And do refactoring
weierophinney
added a commit
that referenced
this pull request
May 17, 2017
Member
|
Thanks, @codisart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.