This repository was archived by the owner on May 16, 2018. It is now read-only.
Fixed bug - do not allow invalid hostname with double dots i.e. zend..com - #348
Merged
Conversation
Contributor
Author
|
This is a regression bug, this used to work in the old zend framework 1 around 2010 :) |
Member
|
Sorry, but I can not found a signed CLA. |
Contributor
Author
|
CLA should be now faxed, can you find it? :) |
Member
|
@pharazon |
froschdesign
added a commit
that referenced
this pull request
Jul 24, 2014
Fixed bug - do not allow invalid hostname with double dots i.e. zend..com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in Zend_Validate_Hostname, accepting invalid hostnames such as zend..com with double dots (empty domain parts). Created a unit test & fix.