Fix nullable type declarations for PHP 8.4 compatibility #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NattyNarwhal
approved these changes
Mar 18, 2025
Contributor
Author
|
@NattyNarwhal I would also like to apply the rule visibility_required. I found that some properties or methods have not declared their visibility. |
Collaborator
Please do! I think there's a few sketchy cases like that. |
…tion order consistency
Blurazzle
force-pushed
the
implicitly-nullable-types
branch
from
75bf4bf to
71df096
Compare
Contributor
Author
|
@NattyNarwhal I have added them to this PR :). What is the process for merging these changes? I see that you have approved this PR as well as PR #217, but they have not been merged yet. Additionally, PR #216 is still awaiting review. |
Collaborator
|
Giving other people a chance to review these; for #216 we'll want to test on i. |
alanseiden
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
nullable_type_declaration_for_default_null_value.visibility_required.