Bump minimum PHP version to 7.1 #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and class constant visibility modifiers.
NattyNarwhal
approved these changes
Apr 1, 2025
Collaborator
NattyNarwhal
left a comment
NattyNarwhal
left a comment
There was a problem hiding this comment.
I wouldn't have a problem personally if we bumped this higher if we want newer features. 7.3 or 7.4 is a safe minimum considering that's the last "classic" Zend Server on IBM i.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this one is also relevant.
This pull request bumps the minimum required PHP version to 7.1 in the composer.json file. The reason for this change is that #218 commit introduced Nullable types and Class constant visibility modifiers, which are features available in PHP 7.1 and later versions.
By updating the minimum PHP version, we prevent potential installation issues for users who are still using older PHP versions. See also the release notes for PHP 7.1: https://www.php.net/releases/7_1_0.php