Skip to content

Conversation

@mbrukman
Copy link

The default link for a workflow badge points to the image itself.
Update link to point to the Actions tab on GitHub with the list of runs.
[skip ci] since we are not modifying any code that would impact CI.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

The default link for a workflow badge points to the image itself.
Update link to point to the Actions tab on GitHub with the list of runs.
[skip ci] since we are not modifying any code that would impact CI.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mbrukman
Copy link
Author

Sorry, I would need to have lawyers review your CLA before signing it, which isn't worth it for a trivial change such as this one.

FWIW, you should clearly state that contributions require signing a CLA in CONTRIBUTING.md which it currently doesn't — I searched again for mentions of either "CLA" or "Contributor License Agreement" and it's not there.

@mbrukman mbrukman closed this Apr 25, 2022
@mbrukman mbrukman deleted the patch-1 branch April 25, 2022 01:25
@htahir1
Copy link
Contributor

htahir1 commented Apr 25, 2022

@mbrukman So sorry that you had to close this PR, and felt blindsided by the CLA. I have remedied this with a clear reference in the CONTRIBUTING.md as per your suggestion (#536). The CLA is just to protect the core contributors as much as it is to everyone contributing to ZenML, and does not mean to be jargon-y. I will bring up with the core team how we can make it easier to understand what the contributing licence is in plain english so that you and others in the future do not get dissuaded to contribute. So sorry for the inconvenience!

@mbrukman
Copy link
Author

@htahir1 wrote:

So sorry that you had to close this PR, and felt blindsided by the CLA. I have remedied this with a clear reference in the CONTRIBUTING.md as per your suggestion (#536).

Thank you for making the change!

The CLA is just to protect the core contributors as much as it is to everyone contributing to ZenML, and does not mean to be jargon-y.

I understand very well what a CLA is and what it does and its purpose; my company uses CLAs and I also set up CLA for a project I helped start in The Linux Foundation (@JanusGraph).

However, I cannot contribute to a project that uses a CLA without my employer's legal review & approval of that CLA, which will take a bunch of time for everyone involved, which as I mentioned, isn't worthwhile for a simple change such as this one. If I or someone else from my company will want to contribute some changes to ZenML in the future, we would have to go through the legal review process at that time.

I will bring up with the core team how we can make it easier to understand what the contributing licence is in plain english so that you and others in the future do not get dissuaded to contribute.

As mentioned above, this is not about the jargon or legal language in the CLA; corporate employees will still have to get their lawyers to review & approve CLAs before accepting them. Thus, since adding a plain language explanation will not enable corporate employees to contribute without a legal review of the CLA, this may not be a good use of your time, but it's up to you, of course.

So sorry for the inconvenience!

No worries! Thank you for your understanding and making the update to CONTRIBUTING.md so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants