ホットリロードが動作しない問題を修正 #585
Merged
ホットリロードが動作しない問題を修正 #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- chokidar.watch()のglobパターンを個別のディレクトリパスに変更 - startLocalChangesWatcher関数を非同期から同期に変更 - watchPathGlobパラメータをwatchPathsに変更し、配列で受け取るように修正 Resolves #584 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- モック関数をmockResolvedValueからmockReturnValueに変更（非同期→同期） - 期待値をglobパターンから配列形式に変更 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
| expect(server.startLocalChangesWatcher).toHaveBeenCalledWith( | ||
| mockReturnServer, | ||
| `${process.cwd()}/{articles,books}/**/*` | ||
| [`${process.cwd()}/articles`, `${process.cwd()}/books`] |
Member
There was a problem hiding this comment.
とくにBooksですが、直下だけでなく再帰的に監視してくれるかわかりますか？Booksは chpater > chapter.md の構造であるため気になりました。
Contributor
Author
There was a problem hiding this comment.
確認しました。 chapter.md の変更も検知してくれるので問題ありません！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chokidarのbreaking changesを見逃していました 🙏
https://github.com/paulmillr/chokidar
📑 Summary
仕様の変更
コードの変更
chokidar.watch()に渡すパスをglobパターンから個別のディレクトリパス配列に変更startLocalChangesWatcher関数の非同期処理を削除（async/awaitを削除）watchPathGlobパラメータをwatchPaths配列に変更その他・備考
{articles,books}/**/*が正しく展開されず、ファイル変更を検知できない問題を修正articles/,books/）を配列で渡すことで、正常にホットリロードが動作するようになりますResolves #584
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストであるより詳しい内容は Pull Request Policy を参照してください。