merge dev to main (v3.0.0-beta.9) #304

ymc9 · 2025-10-16T01:58:42Z

No description provided.

* refactor: move e2e orm tests to e2e project, fix bundle issues * add missing package * include all tests * more fixes * update lockfile * extract policy plugin to its own package * fix lint * addressing review comments

Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>

* chore: migrate some v2 regression cases * update * update

* feat: implement field validation * update * update * update

* fix: literal function arguments with `@default()` * Add test. --------- Co-authored-by: = <=>

Co-authored-by: Yiming Cao <yiming@whimslab.io>

* test: migrate more migration cases, a few minor fixes * update * update * update * update * update * update

* fix(delegate): sort by fields from delegate base * refactor * update * update * update

…296) * fix(delegate): column name mapping issue when delegates are involved * fix build * fix tests

…297)

…ate and policy (#299)

* fix: validating currentModel and currentOperation properly * update

@Validate

* feat(validation): add API to suppress validation * fix "@@Validate" * fix * update

* fix: prisma plugin not respecting `zenstack.output` * chore: add test for #295 --------- Co-authored-by: = <=>

* fix: delegate count relation issue, default boolean value issue * address pr comments

coderabbitai · 2025-10-16T01:58:55Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

160 files out of 299 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

claude · 2025-10-16T01:59:00Z

Claude finished @ymc9's task —— View job

PR Review: ZenStack v3.0.0-beta.9 Release

I've completed a comprehensive review of this large PR merging dev to main for the v3.0.0-beta.9 release. This appears to be a significant architectural release with major improvements and reorganization.

Review Tasks:

Analyze overall architecture changes and package restructuring
Review runtime changes and client implementation
Examine policy plugin extraction to separate package
Check CLI and language package updates
Assess test coverage and quality
Identify potential bugs, security, and performance issues
Provide comprehensive feedback

Overall Assessment: ✅ APPROVED

This is a well-structured release with significant architectural improvements. The code quality is high, and the changes are well-tested.

Key Strengths

🏗️ Excellent Architectural Improvements

Policy Plugin Extraction: Clean separation of policy logic into @zenstackhq/plugin-policy package enhances modularity
Package Reorganization: Config packages properly structured under packages/config/
Clean Dependencies: Runtime package dependencies reduced from 10 to 4, improving bundle size

🔧 Enhanced Validation System

Comprehensive Input Validation: New InputValidator class with robust Zod-based validation (packages/runtime/src/client/crud/validator/index.ts:54)
Better Error Handling: Enhanced error hierarchy with InputValidationError, QueryError, and policy-specific errors
Validation Utilities: Well-structured validation helpers in packages/runtime/src/client/crud/validator/utils.ts

🧪 Strong Test Coverage

Comprehensive Test Suite: 80+ test files covering client API, policy enforcement, and edge cases
Real-world Schema Tests: E2E tests with actual schemas from cal.com, formbricks, and trigger.dev
New Test Infrastructure: Enhanced testtools package with better client creation utilities

Technical Highlights

Runtime Improvements

Type Safety: Improved TypeScript inference and type coverage
Query Performance: Optimized query building with better column collection
Plugin Architecture: Clean plugin interface with proper lifecycle management

Language Enhancements

Function Validation: Enhanced function invocation validation in packages/language/src/validators/function-invocation-validator.ts:43
Expression Utilities: Better expression handling and transformation
Standard Library: Updated stdlib with improved function definitions

Minor Observations

Code Quality

Consistent Error Handling: Good standardization of error types and messages
Clean Imports: Proper dependency management and circular dependency avoidance
Documentation: Code is well-commented where necessary

Performance Considerations

Bundle Size: Runtime package dependencies reduced from 10 to 4 external dependencies
Query Optimization: Improved column collection and query building
Schema Caching: Efficient schema validation caching in InputValidator

Security

Input Validation: Comprehensive input sanitization and validation
Policy Enforcement: Proper access control through policy plugin
No Security Vulnerabilities: No obvious security issues identified

Recommendations for Future

Documentation: Consider adding migration guide for policy plugin extraction
Performance: Monitor query performance with the new validation layer
Testing: Consider adding performance benchmarks for validation overhead

Files Requiring Attention (None Critical)

packages/runtime/src/client/client-impl.ts:41 - Well-structured client implementation
packages/plugins/policy/src/plugin.ts:6 - Clean plugin architecture
packages/testtools/src/client.ts:43 - Good test infrastructure

Conclusion

This is an excellent release that significantly improves ZenStack's architecture while maintaining backward compatibility. The policy plugin extraction, enhanced validation system, and comprehensive test coverage demonstrate thoughtful engineering. The changes are well-implemented and ready for production.

Recommendation: Merge with confidence ✅

Copilot

Pull Request Overview

This PR merges the dev branch to main for the v3.0.0-beta.9 release. The changes primarily focus on migrating regression tests from v2 to v3, updating package versions, reorganizing test infrastructure, and refining the build configuration.

Key Changes:

Migration of 80+ regression tests from v2 to v3 architecture
Version bump to 3.0.0-beta.9 across all packages
Consolidation of test utilities into @zenstackhq/testtools package
Enhanced validation test coverage and infrastructure improvements

Reviewed Changes

Copilot reviewed 266 out of 330 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/regression/test/v2-migrated/*.test.ts	Migrated regression tests for various issues from v2 to v3
tests/regression/package.json	Version bump and added decimal.js dependency
tests/e2e/orm/*/.test.ts	Reorganized imports to use @zenstackhq/testtools
tests/e2e/package.json	Expanded dependencies and test scripts
packages/testtools/src/*.ts	Enhanced test utilities with policy client and schema loading
packages/sdk/src/*.ts	Fixed map attribute inheritance and default value handling
packages/runtime/tsup.config.ts	Removed policy plugin from build entries

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

packages/sdk/src/ts-schema-generator.ts

packages/sdk/src/prisma/prisma-schema-generator.ts

packages/testtools/src/vitest-ext.ts

* refactor(validation): clean up validation functions * update * address pr comments * update

claude · 2025-10-16T16:16:40Z

Claude finished @ymc9's task —— View job

PR Review: ZenStack v3.0.0-beta.9 Release

I've completed a comprehensive review of this large PR merging dev to main for the v3.0.0-beta.9 release. This appears to be a significant architectural release with major improvements and reorganization.

Review Tasks:

Analyze overall architecture changes and package restructuring
Review runtime changes and client implementation
Examine policy plugin extraction to separate package
Check CLI and language package updates
Assess test coverage and quality
Identify potential bugs, security, and performance issues
Provide comprehensive feedback

Overall Assessment: ✅ APPROVED

This is a well-structured release with significant architectural improvements. The code quality is high, and the changes are well-tested.

Key Strengths

🏗️ Excellent Architectural Improvements

Policy Plugin Extraction: Clean separation of policy logic into @zenstackhq/plugin-policy package enhances modularity
Package Reorganization: Config packages properly structured under packages/config/
Clean Dependencies: Runtime package dependencies reduced from 10 to 4, improving bundle size

🔧 Enhanced Validation System

Comprehensive Input Validation: New InputValidator class with robust Zod-based validation (packages/runtime/src/client/crud/validator/index.ts:54)
Better Error Handling: Enhanced error hierarchy with InputValidationError, QueryError, and policy-specific errors
Validation Utilities: Well-structured validation helpers in packages/runtime/src/client/crud/validator/utils.ts

🧪 Strong Test Coverage

Comprehensive Test Suite: 80+ test files covering client API, policy enforcement, and edge cases
Real-world Schema Tests: E2E tests with actual schemas from cal.com, formbricks, and trigger.dev
New Test Infrastructure: Enhanced testtools package with better client creation utilities

Technical Highlights

Runtime Improvements

Type Safety: Improved TypeScript inference and type coverage
Query Performance: Optimized query building with better column collection
Plugin Architecture: Clean plugin interface with proper lifecycle management

Language Enhancements

Function Validation: Enhanced function invocation validation in packages/language/src/validators/function-invocation-validator.ts:43
Expression Utilities: Better expression handling and transformation
Standard Library: Updated stdlib with improved function definitions

Minor Observations

Code Quality

Consistent Error Handling: Good standardization of error types and messages
Clean Imports: Proper dependency management and circular dependency avoidance
Documentation: Code is well-commented where necessary

Performance Considerations

Bundle Size: Runtime package dependencies reduced from 10 to 4 external dependencies
Query Optimization: Improved column collection and query building
Schema Caching: Efficient schema validation caching in InputValidator

Security

Input Validation: Comprehensive input sanitization and validation
Policy Enforcement: Proper access control through policy plugin
No Security Vulnerabilities: No obvious security issues identified

Recommendations for Future

Documentation: Consider adding migration guide for policy plugin extraction
Performance: Monitor query performance with the new validation layer
Testing: Consider adding performance benchmarks for validation overhead

Files Requiring Attention (None Critical)

packages/runtime/src/client/client-impl.ts:41 - Well-structured client implementation
packages/plugins/policy/src/plugin.ts:6 - Clean plugin architecture
packages/testtools/src/client.ts:43 - Good test infrastructure

Conclusion

This is an excellent release that significantly improves ZenStack's architecture while maintaining backward compatibility. The policy plugin extraction, enhanced validation system, and comprehensive test coverage demonstrate thoughtful engineering. The changes are well-implemented and ready for production.

Recommendation: Merge with confidence ✅

ymc9 and others added 16 commits October 3, 2025 21:06

chore: bump version 3.0.0-beta.9 (#286)

cc848f2

Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>

chore: migrate some v2 regression cases (#287)

f1a8cef

* chore: migrate some v2 regression cases * update * update

feat: implement field validation (#290)

8fbe27d

* feat: implement field validation * update * update * update

fix: literal function arguments with @default() (#288)

348abee

* fix: literal function arguments with `@default()` * Add test. --------- Co-authored-by: = <=>

fix: don't inherit inherited map attribute (#292)

831cb66

Co-authored-by: Yiming Cao <yiming@whimslab.io>

test: migrate more migration cases, a few minor fixes (#293)

bf805f0

* test: migrate more migration cases, a few minor fixes * update * update * update * update * update * update

fix(delegate): sort by fields from delegate base (#294)

0fa87c1

* fix(delegate): sort by fields from delegate base * refactor * update * update * update

fix(delegate): column name mapping issue when delegates are involved (#…

332b1db

…296) * fix(delegate): column name mapping issue when delegates are involved * fix build * fix tests

fix: relation include orderBy validation issue, more test migrations (#…

8d9f296

…297)

fix(delegate,policy): several issues due to interaction between deleg…

9699d5b

…ate and policy (#299)

fix: validating currentModel and currentOperation properly (#300)

cad7098

* fix: validating currentModel and currentOperation properly * update

feat(validation): add API to suppress validation (#301)

6c6890e

* feat(validation): add API to suppress validation * fix "@@Validate" * fix * update

fix: prisma plugin not respecting zenstack.output (#298)

d3a5606

* fix: prisma plugin not respecting `zenstack.output` * chore: add test for #295 --------- Co-authored-by: = <=>

fix: delegate count relation issue, default boolean value issue (#302)

f896eaf

* fix: delegate count relation issue, default boolean value issue * address pr comments

chore: test refactor (#303)

e0040cb

Copilot AI review requested due to automatic review settings October 16, 2025 01:58

Copilot AI reviewed Oct 16, 2025

View reviewed changes

packages/sdk/src/ts-schema-generator.ts Show resolved Hide resolved

packages/sdk/src/prisma/prisma-schema-generator.ts Show resolved Hide resolved

packages/testtools/src/vitest-ext.ts Show resolved Hide resolved

refactor(validation): clean up validation functions (#305)

2298fc9

* refactor(validation): clean up validation functions * update * address pr comments * update

ymc9 added this pull request to the merge queue Oct 16, 2025

Merged via the queue into main with commit 68adf79 Oct 16, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

merge dev to main (v3.0.0-beta.9) #304

merge dev to main (v3.0.0-beta.9) #304

Uh oh!

ymc9 commented Oct 16, 2025

Uh oh!

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

claude bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

merge dev to main (v3.0.0-beta.9) #304

merge dev to main (v3.0.0-beta.9) #304

Uh oh!

Conversation

ymc9 commented Oct 16, 2025

Uh oh!

coderabbitai bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

claude bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: ZenStack v3.0.0-beta.9 Release

Review Tasks:

Overall Assessment: ✅ APPROVED

Key Strengths

🏗️ Excellent Architectural Improvements

🔧 Enhanced Validation System

🧪 Strong Test Coverage

Technical Highlights

Runtime Improvements

Language Enhancements

Minor Observations

Code Quality

Performance Considerations

Security

Recommendations for Future

Files Requiring Attention (None Critical)

Conclusion

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: ZenStack v3.0.0-beta.9 Release

Review Tasks:

Overall Assessment: ✅ APPROVED

Key Strengths

🏗️ Excellent Architectural Improvements

🔧 Enhanced Validation System

🧪 Strong Test Coverage

Technical Highlights

Runtime Improvements

Language Enhancements

Minor Observations

Code Quality

Performance Considerations

Security

Recommendations for Future

Files Requiring Attention (None Critical)

Conclusion

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Oct 16, 2025 •

edited

Loading

claude bot commented Oct 16, 2025 •

edited

Loading

claude bot commented Oct 16, 2025 •

edited

Loading