fix(strategy): validate n before Backend construction in runner#268
Merged
Merged
Conversation
github-actions
Bot
added
area:strategy
Mirror matmul.runner's Integral/positive-n guard in strategy.runner.run and compare so invalid n fails with a clear ValueError before device setup, instead of reaching Backend or allocate.
github-actions
Bot
added
the
status:ready-non-gpu
This was referenced Jul 16, 2026
5 tasks
zeokin
added a commit
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strategy.runner.run/compareconstructedBackendbefore validatingn, unlikematmul.runnerwhich already rejects non-Integral / non-positivenearly._require_positive_nguard (rejectbool, non-Integral,< 1) before device setup in both entry points.tests/test_public_api_boundaries.pywith a_NoBackendstub so invalidnis proven to fail before backend construction.Test plan
uv run --extra test python -m pytest tests/test_public_api_boundaries.py -vuv run python -m strategy.smoke