Skip to content

[DEV-9587] missing backrefs#233

Merged
charlta merged 4 commits into
mainfrom
DEV-9587-missing-backrefs
Jul 13, 2026
Merged

[DEV-9587] missing backrefs#233
charlta merged 4 commits into
mainfrom
DEV-9587-missing-backrefs

Conversation

@Boris-Filin

@Boris-Filin Boris-Filin commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description

Add backfill for lists that have one in JVM;

Add collection backfill tests mirroring java

Associated tasks

Test Steps

Run tests lol

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

@Boris-Filin
Boris-Filin marked this pull request as ready for review July 9, 2026 07:06
@Boris-Filin
Boris-Filin requested review from charlta and chestm007 July 9, 2026 07:06
@charlta
charlta marked this pull request as draft July 9, 2026 12:05
@charlta

charlta commented Jul 9, 2026

Copy link
Copy Markdown
Member

Marked as draft pending outcomes of the review on zepben/ewb-sdk-jvm#276

The tests here can likely be updated to match.

@Boris-Filin
Boris-Filin force-pushed the DEV-9587-missing-backrefs branch from 20db950 to 88a3be4 Compare July 13, 2026 01:45
Comment thread src/zepben/ewb/model/cim/iec61970/base/core/geographical_region.py
Comment thread test/cim/iec61970/base/wires/test_ac_line_segment.py
Comment thread test/cim/iec61970/base/wires/test_ac_line_segment.py
@Boris-Filin
Boris-Filin marked this pull request as ready for review July 13, 2026 01:54
@charlta charlta changed the title Dev 9587 missing backrefs [DEV-9587] missing backrefs Jul 13, 2026

@charlta charlta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add appropriate change log entries for new backref functionality, noting the breaking requires checks

@charlta
charlta marked this pull request as draft July 13, 2026 05:13
@Boris-Filin
Boris-Filin marked this pull request as ready for review July 13, 2026 05:40
@Boris-Filin
Boris-Filin requested a review from charlta July 13, 2026 05:40
Boris Filin added 4 commits July 13, 2026 16:16
Signed-off-by: Boris Filin <boris.filin@zepben.com>

# Conflicts:
#	src/zepben/ewb/model/cim/iec61970/base/core/geographical_region.py
#	src/zepben/ewb/model/cim/iec61970/base/core/sub_geographical_region.py
#	src/zepben/ewb/model/cim/iec61970/base/core/substation.py
#	src/zepben/ewb/model/cim/iec61970/base/wires/energy_consumer.py
#	src/zepben/ewb/model/cim/iec61970/base/wires/energy_source.py
…tests for cuts, clamps, power_transformer_ends, substation feeders

Signed-off-by: Boris Filin <boris.filin@zepben.com>
…of lambdas; Test now checks the error message; Clean up backfill error messages

Signed-off-by: Boris Filin <boris.filin@zepben.com>
Signed-off-by: Boris Filin <boris.filin@zepben.com>

# Conflicts:
#	changelog.md
@Boris-Filin
Boris-Filin force-pushed the DEV-9587-missing-backrefs branch from 2de3131 to 32cb5cc Compare July 13, 2026 06:17
@Boris-Filin

Copy link
Copy Markdown
Contributor Author

Re-rebased onto main to reflect latest changes

@charlta
charlta merged commit 4a115ed into main Jul 13, 2026
8 checks passed
@charlta
charlta deleted the DEV-9587-missing-backrefs branch July 13, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants