sensors: icm42688: Do not force rc oscillator #60552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing the usage of the RC oscillator and keeping it on turns out to have detrimental effects to the readings by default. The default clock mode settings are perfectly fine. Signed-off-by: Tom Burdick <thomas.burdick@intel.com>
yperess
approved these changes
Jul 18, 2023
aasinclair
approved these changes
Jul 19, 2023
Member
|
@teburd Thanks! this is a huge improvement! |
bperseghetti
approved these changes
Jul 19, 2023
PetervdPerk-NXP
approved these changes
Jul 19, 2023
jgoppert
approved these changes
Jul 20, 2023
kartben
added a commit
to kartben/zephyr
that referenced
this pull request
Dec 4, 2025
Last activity: 18 months ago (review) Recent activities: - review: Review on 'drivers: input: sbus remote controller support' zephyrproject-rtos#72628 (2024-05-26T21:59:03Z) - review: Review on 'zbus: improve the way of storing observers' zephyrproject-rtos#60713 (2023-08-28T18:07:20Z) - review: Review on 'sensors: icm42688: Do not force rc oscillator' zephyrproject-rtos#60552 (2023-07-20T00:37:34Z) Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing the usage of the RC oscillator and keeping it on turns out to have detrimental effects to the readings by default. The default clock mode settings are perfectly fine.
Fixes #60549