drivers: i2c: stm32: Fix size calculation of n_timings #90402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`timings` is an array of `struct i2c_config_timing` (3 x `uint32_t`). `i2c_timings_##index` is an array of `uint32_t` (hence the cast when it is assigned to `timings`). Therefore `ARRAY_SIZE(i2c_timings_##index)` is off by a factor 3 when used for `n_timings`. Parentheses around the second `sizeof` are there to silence the gcc warning (-Wsizeof-array-div) that warns about not computing the size of `i2c_timings_##index`. Signed-off-by: Wouter Horré <wouter@versasense.com>
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
teburd
JarmouniA
approved these changes
May 23, 2025
|
gautierg-st
approved these changes
May 26, 2025
erwango
approved these changes
May 26, 2025
mathieuchopstm
approved these changes
May 26, 2025
JarmouniA
added
backport v3.7-branch
JarmouniA
added
backport v3.7-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timingsis an array ofstruct i2c_config_timing(3 xuint32_t).i2c_timings_##indexis an array ofuint32_t(hence the cast when it is assigned totimings). ThereforeARRAY_SIZE(i2c_timings_##index)is off by a factor 3 when used forn_timings.Parentheses around the second
sizeofare there to silence the gcc warning (-Wsizeof-array-div) that warns about not computing the size ofi2c_timings_##index.