Drivers: stm32: i2c rtio: Fix 'timings' array size #90805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'timings' is an array of 'struct i2c_config_timing' (3 x uint32_t). 'i2c_timings_##index' is an array of uint32_t (hence the cast when it is assigned to 'timings'). Therefore 'ARRAY_SIZE(i2c_timings_##index)' is off by a factor 3 when used for n_timings. Signed-off-by: Abderrahmane JARMOUNI <git@jarmouni.me>
JarmouniA
added
bug
|
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
teburd
teburd
approved these changes
May 29, 2025
Contributor
teburd
left a comment
teburd
left a comment
There was a problem hiding this comment.
This should likely be done in a common config struct for all driver variants, but the change is small here and likely fixing a bug?
Contributor
Author
gautierg-st
approved these changes
Jun 3, 2025
etienne-lms
approved these changes
Jun 3, 2025
erwango
approved these changes
Jun 6, 2025
Member
Indeed, this is for this king of issues I asked for refactoring of the RTIO introduction PR before it was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #90402