Support imx93 video pll driver #98554

RuoshanShi · 2025-10-30T08:32:26Z

Added video pll driver to support i.MX93 display. Different screens require different VIDEO PLL configurations.
Added rm67199 driver for i.MX93 evk board
Added MX8_DSI_OLED1A shield and enable the display on imx93_evk/mimx9352/m33/ddr
Added display tests to run the nxp_mx8_dsi_oled1a shield

RuoshanShi · 2025-11-19T06:38:37Z

Please fix conflictions.

@JiafeiPan The conflicts have been fixed

RuoshanShi · 2025-11-24T08:20:55Z

@mmahadevan108 Could you please help review this pull request?

JarmouniA · 2025-11-24T11:09:55Z

dts/bindings/display/raydium,rm67199.yaml

+    description:
+      Number of data lanes.
+
+  pixel-format:


zephyr/dts/bindings/mipi-dsi/mipi-dsi-device.yaml

Line 20 in c9b01e8

pixel-format:

zephyr/dts/bindings/mipi-dsi/mipi-dsi-device.yaml

Line 20 in c9b01e8

pixel-format:

Removed the repeat code

JarmouniA · 2025-11-24T11:10:40Z

dts/bindings/display/raydium,rm67199.yaml

+# SPDX-License-Identifier: Apache-2.0
+#
+
+description: Raydium RM67199 Panel


Suggested change

description: Raydium RM67199 Panel

description: Raydium RM69380 controller for DSI panels

Fixed to " Raydium RM67199 controller for DSI panels"

JarmouniA · 2025-11-24T11:11:33Z

drivers/misc/nxp_imx93_video_pll/nxp_video_pll_ctrl.c

This should be in SoC's or board's initialization code, does not fit the driver definition.

This should be in SoC's or board's initialization code, does not fit the driver definition.

Thank you for your review. The VIDEO_PLL operation indeed needs to be handled at the SoC stage. I made this change because on the iMX93 we need to support multiple panels, different shields require separate configuration of the VIDEO_PLL frequency. By implementing it as an independent clock control driver, we can configure the VIDEO_PLL frequency more flexibly.

JarmouniA · 2025-11-24T11:12:11Z

drivers/display/Kconfig.rm67199

+# SPDX-License-Identifier: Apache-2.0
+
+config RM67199
+	bool "RM67199 display driver"


Suggested change

bool "RM67199 display driver"

bool "RM67199 display controller driver"

JarmouniA · 2025-11-24T11:12:42Z

drivers/display/Kconfig.rm67199

+	select MIPI_DSI
+	depends on DT_HAS_RAYDIUM_RM67199_ENABLED
+	help
+	  Enable driver for RM67199 display.


Suggested change

Enable driver for RM67199 display.

Enable driver for RM67199 display controller.

JarmouniA · 2025-11-24T11:15:27Z

drivers/display/display_rm67199.c

+
+	if (config->bl_gpio.port != NULL) {
+		return gpio_pin_set_dt(&config->bl_gpio, 1);
+	} else {


Suggested change

} else {

}

JarmouniA · 2025-11-24T11:17:03Z

drivers/display/display_rm67199.c

+	.set_orientation = rm67199_set_orientation,
+};
+
+#define RM67199_PANEL(id)                                                                          \


Suggested change

#define RM67199_PANEL(id) \

#define RM67199_CONTROLLER(id) \

replace all instances.

replace all instances.

Fixed

JarmouniA · 2025-11-24T11:20:29Z

boards/shields/nxp_mx8_dsi_oled1a/doc/index.rst

+Overview
+********
+
+The NXP MX8 DSI OLED1A Panel is a high-resolution OLED display panel


Suggested change

The NXP MX8 DSI OLED1A Panel is a high-resolution OLED display panel

The NXP MX8 DSI OLED1A shield is a high-resolution OLED display panel

JarmouniA · 2025-11-24T11:20:49Z

boards/shields/nxp_mx8_dsi_oled1a/doc/index.rst

+The NXP MX8 DSI OLED1A Panel is a high-resolution OLED display panel
+designed for use with NXP i.MX8 series processors. This panel provides
+excellent color reproduction and contrast ratio through OLED technology.
+The display connects via MIPI DSI interface and offers superior visual


Suggested change

The display connects via MIPI DSI interface and offers superior visual

The display shield connects via MIPI DSI interface and offers superior visual

JarmouniA · 2025-11-24T11:21:32Z

boards/shields/nxp_mx8_dsi_oled1a/doc/index.rst

+
+.. target-notes::
+
+.. _NXP MX8 DSI OLED1A Panel website:


Suggested change

.. _NXP MX8 DSI OLED1A Panel website:

.. _NXP MX8 DSI OLED1A Shield website:

Fixed the name

Added nxp_imx93_video_pll driver to support display function Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

Added video_pll instance to soc dtsi. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

Added rm67199 driver for i.MX93 display. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com> Signed-off-by: Winteri Wang <dongjie.wang@nxp.com>

Added MX8_DSI_OLED1A panel and enable display on imx93_evk ddr target Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

Updated display tests to run the nxp_mx8_dsi_oled1a shield. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

Fix pointer-to-integer cast error by using uintptr_t intermediate cast instead of direct uint64_t cast. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

Sync hal_nxp repo Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

github-actions · 2025-11-26T08:25:46Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`a7f64ac`	zephyrproject-rtos/hal_nxp#640	zephyrproject-rtos/hal_nxp#640/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

sonarqubecloud · 2025-11-26T08:51:14Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.1% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added area: ARM64 ARM (64-bit) Architecture area: MIPI-DSI area: Boards/SoCs platform: NXP NXP area: Display area: Shields Shields (add-on boards) area: Devicetree Bindings platform: NXP MPU labels Oct 30, 2025

zephyrbot requested review from JiafeiPan, VynDragon, Zhiqiang-Hou, avisconti, danieldegrasse, dbaluta, decsny, dleach02, erwango, iuliana-prodan, jfischer-no, kartben, manuargue, mmahadevan108 and yangbolu1991 October 30, 2025 08:34

zephyrbot assigned kartben Oct 30, 2025

RuoshanShi force-pushed the support_imx93_video_pll_driver branch 6 times, most recently from 314a0fe to cab91a5 Compare November 2, 2025 07:40

RuoshanShi dismissed JiafeiPan’s stale review via f534366 November 19, 2025 06:37

RuoshanShi force-pushed the support_imx93_video_pll_driver branch from 790ca66 to f534366 Compare November 19, 2025 06:37

zephyrbot requested review from JarmouniA and JiafeiPan November 19, 2025 06:39

RuoshanShi mentioned this pull request Nov 19, 2025

Support mipi dsi on imx95 #93134

Open

JiafeiPan previously approved these changes Nov 20, 2025

View reviewed changes

JarmouniA requested changes Nov 24, 2025

View reviewed changes

RuoshanShi dismissed JiafeiPan’s stale review via 2d88f2c November 25, 2025 06:28

RuoshanShi force-pushed the support_imx93_video_pll_driver branch from f534366 to 2d88f2c Compare November 25, 2025 06:28

zephyrbot added the area: Tests Issues related to a particular existing or missing test label Nov 25, 2025

zephyrbot requested review from JarmouniA, JiafeiPan and nashif November 25, 2025 06:29

RuoshanShi mentioned this pull request Nov 26, 2025

devices: MIMX9352: Update clock code to avoid array-bounds warning zephyrproject-rtos/hal_nxp#640

Open

RuoshanShi added 7 commits November 26, 2025 17:19

drivers: misc: add NXP i.MX93 Video PLL driver support

61548a6

Added nxp_imx93_video_pll driver to support display function Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

soc: imx93: enable imx93 video pll

e675372

Added video_pll instance to soc dtsi. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

drivers: display: add RM67199 driver support

20f5385

Added rm67199 driver for i.MX93 display. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com> Signed-off-by: Winteri Wang <dongjie.wang@nxp.com>

boards: nxp: add shield of NXP MX8_DSI_OLED1A for imx93_evk

b7b5dab

Added MX8_DSI_OLED1A panel and enable display on imx93_evk ddr target Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

tests: drivers: Add nxp_mx8_dsi_oled1a to display tests

29e18d8

Updated display tests to run the nxp_mx8_dsi_oled1a shield. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

drivers: display: mcux_lcdifv3: fix pointer cast warning

3feddb4

Fix pointer-to-integer cast error by using uintptr_t intermediate cast instead of direct uint64_t cast. Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

west.yml: Update hal_nxp revision

0e634aa

Sync hal_nxp repo Signed-off-by: Ruoshan Shi <ruoshan.shi@nxp.com>

RuoshanShi force-pushed the support_imx93_video_pll_driver branch from 81429d4 to 0e634aa Compare November 26, 2025 08:24

github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Nov 26, 2025

zephyrbot requested a review from ZhaoxiangJin November 26, 2025 08:26

	description: Raydium RM67199 Panel
	description: Raydium RM69380 controller for DSI panels

	bool "RM67199 display driver"
	bool "RM67199 display controller driver"

	Enable driver for RM67199 display.
	Enable driver for RM67199 display controller.

	The NXP MX8 DSI OLED1A Panel is a high-resolution OLED display panel
	The NXP MX8 DSI OLED1A shield is a high-resolution OLED display panel

	The display connects via MIPI DSI interface and offers superior visual
	The display shield connects via MIPI DSI interface and offers superior visual

	.. _NXP MX8 DSI OLED1A Panel website:
	.. _NXP MX8 DSI OLED1A Shield website:

Support imx93 video pll driver #98554

Are you sure you want to change the base?

Support imx93 video pll driver #98554

Conversation

RuoshanShi commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RuoshanShi commented Nov 19, 2025

Uh oh!

RuoshanShi commented Nov 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

sonarqubecloud bot commented Nov 26, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RuoshanShi commented Oct 30, 2025 •

edited

Loading