Use -fno-common to avoid linker warnings#13
Merged
pepone merged 1 commit intozeroc-ice:masterfrom Dec 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the -fno-common compiler flag to resolve linker warnings about section alignment reduction that occur when building mcpp on macOS. The flag tells the compiler to place uninitialized global variables in the BSS section rather than as common symbols, which prevents the __DATA,__common section alignment issues.
Key Changes
- Added
-fno-commoncompiler flag to the Swift Package Manager build configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bernardnormier
approved these changes
Dec 2, 2025
externl
approved these changes
Dec 2, 2025
pepone
pushed a commit
to pepone/mcpp
that referenced
this pull request
Jan 19, 2026
…r overflow in the do_msg() function https://sourceforge.net/p/mcpp/bugs/13/ and CVE-2019-14274 Description: Fix for a bug reported to sourceforge.net zeroc-ice#13 by fixing error messages. Also, fix erroneous messages. Author: NIIBE Yutaka The buffer overflow was caused by do_msg() treating illegal control characters in the error message output as tokenized macros that needed to be expanded for printing. This fixes the problem by just not printing the preprocessed source code which contains those illegal control characters. The patch has been reworked to change the error messages to better match those that are output when unterminated strings are encountered. It also changes the other patched messages to restore the 'l' in "%02lx" because do_msg() passes a long integer to mcpp_fprintf().
pepone
added a commit
that referenced
this pull request
Jan 19, 2026
…r overflow in the do_msg() function (#15) https://sourceforge.net/p/mcpp/bugs/13/ and CVE-2019-14274 Description: Fix for a bug reported to sourceforge.net #13 by fixing error messages. Also, fix erroneous messages. Author: NIIBE Yutaka The buffer overflow was caused by do_msg() treating illegal control characters in the error message output as tokenized macros that needed to be expanded for printing. This fixes the problem by just not printing the preprocessed source code which contains those illegal control characters. The patch has been reworked to change the error messages to better match those that are output when unterminated strings are encountered. It also changes the other patched messages to restore the 'l' in "%02lx" because do_msg() passes a long integer to mcpp_fprintf(). Co-authored-by: John Brandwood <john.brandwood@telzey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With master:
With this branch:
See also https://mplayerhq.hu/pipermail/ffmpeg-devel/2025-May/343062.html