Apply modified Debian 05-gniibe-fix-13.patch#15
Merged
pepone merged 1 commit intozeroc-ice:masterfrom Jan 19, 2026
Merged
Conversation
…r overflow in the do_msg() function https://sourceforge.net/p/mcpp/bugs/13/ and CVE-2019-14274 Description: Fix for a bug reported to sourceforge.net zeroc-ice#13 by fixing error messages. Also, fix erroneous messages. Author: NIIBE Yutaka The buffer overflow was caused by do_msg() treating illegal control characters in the error message output as tokenized macros that needed to be expanded for printing. This fixes the problem by just not printing the preprocessed source code which contains those illegal control characters. The patch has been reworked to change the error messages to better match those that are output when unterminated strings are encountered. It also changes the other patched messages to restore the 'l' in "%02lx" because do_msg() passes a long integer to mcpp_fprintf().
|
|
There was a problem hiding this comment.
Pull request overview
This PR applies a modified Debian patch to fix CVE-2019-14274, a heap-based buffer overflow vulnerability in the do_msg() function. The vulnerability was caused by do_msg() treating illegal control characters in error messages as tokenized macros that needed expansion, leading to potential buffer overflows.
Changes:
- Modified error message format strings to fix typos and improve consistency
- Changed error calls to pass safe constant strings instead of potentially dangerous buffer contents
- Ensured format specifiers correctly match the long integer arguments being passed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
externl
approved these changes
Jan 19, 2026
bernardnormier
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix heap-based buffer overflow in the do_msg() function
https://sourceforge.net/p/mcpp/bugs/13/ and CVE-2019-14274
Description: Fix for a bug reported to sourceforge.net #13
by fixing error messages.
Also, fix erroneous messages.
Author: NIIBE Yutaka
The buffer overflow was caused by do_msg() treating illegal control characters in the error message output as tokenized macros that needed to be expanded for printing.
This fixes the problem by just not printing the preprocessed source code which contains those illegal control characters.
The patch has been reworked to change the error messages to better match those that are output when unterminated strings are encountered. It also changes the other patched messages to restore the 'l' in "%02lx" because do_msg() passes a long integer to mcpp_fprintf().