Add note about TSS direct deposit support #557
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe pull request updates the documentation for blockchain functionalities by introducing the "TSS Direct Deposits" feature for EVM chains and refreshing Solana’s “Withdraw and call” dates. The new TSS feature is clearly marked with a warning and is limited to Ethereum. Additionally, the operational dates for both fungible and native token withdrawal functionalities on Solana have been revised from Feb 25 to Mar 10, with support now explicitly indicated. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant UI as User Interface
participant BS as Backend Service
participant EC as Ethereum Chain
U->>UI: Initiate TSS Direct Deposit
UI->>BS: Validate EVM chain
alt Chain is Ethereum
BS->>EC: Execute deposit to TSS address
EC-->>BS: Deposit confirmation
BS-->>UI: Return success status
else Non-Ethereum Chain
BS-->>UI: Return error (feature disabled)
end
UI-->>U: Display deposit status
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/pages/developers/chains/functionality.mdx (2)
10-10: TSS Direct Deposits Table Row Addition
The new row for TSS Direct Deposits is clearly added with the appropriate warning symbols (⚠️ ) on Mainnet, Testnet, and E2E, while indicating that it is disabled (❌) on Localnet. To further improve transparency, consider including a reference (or footnote) to GitHub issue #3579 so that users can easily understand the context behind the feature being disabled on non-Ethereum chains.
65-68: TSS Direct Deposits Terminology Clarification
The added definition under Terminology for TSS Direct Deposits succinctly explains that transfers are made directly to the TSS address on EVM Connected Chains, and that the feature is only supported on Ethereum while being disabled on all other EVM chains. For added clarity, consider referencing GitHub issue #3579 to inform readers of the underlying reason for the limitation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/developers/chains/functionality.mdx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
src/pages/developers/chains/functionality.mdx (2)
21-22: Solana Withdrawal Date Update Verification
The updated rows for Withdraw and call (fungible token) and Withdraw and call (native coin) on Solana now reflect the new scheduled date ("Mar 10") in the Testnet column instead of the previous "Feb 25". Please verify that these date updates are consistent with the latest deployment timeline and related documentation.
73-75: E2E Environment Definition Update
The updated definition for E2E now provides a clear and concise explanation along with a direct link to the protocol-level development environment. This addition enhances clarity for readers.
This feature is being disabled as part of zeta-chain/node#3579
Summary by CodeRabbit
New Features
Documentation