docs: record the standing axiom admin token and metrics dataset api - #606
Conversation
The vault's admin-token (create/read/update on datasets, monitors, notifiers, dashboards - no deletes) replaces short-lived UI tokens for agent-driven administration; the v2 dataset API creates the metrics dataset directly with kind otel:metrics:v1, so the UI-only claim goes. The notifier's real name is vers alarms, not vers alerts.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe documentation updates revise Axiom token sourcing, explicitly provision the ChangesObservability documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/architecture/deployment.md`:
- Around line 348-356: Add strict shell mode before the Axiom provisioning
commands and update both curl invocations in the dataset-creation loop and
metrics creation request to use fail-fast, show-error behavior. Keep the
existing endpoints, authorization, and payloads unchanged so any provisioning
failure stops the script visibly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: bbd07e8c-a445-42af-a090-66ba64bf5455
📒 Files selected for processing (2)
docs/architecture/deployment.mddocs/architecture/observability.md
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Description
Aligns the deployment and observability docs with the provisioned Axiom reality.
admin-token(create/read/update on datasets, monitors, notifiers, dashboards — no deletes) is the standing credential for agent-driven administration; short-lived UI tokens remain only for destructive operationskind: otel:metrics:v1) — drops the claim that the UI is requiredvers alarms, notvers alertsTesting
bun run typecheckpassesbun run testpassesbun run lintpasses