chore: improve types, migrate griffith-standalone to ts#207
Merged
ambar merged 5 commits intozhihu:masterfrom Sep 13, 2021
Merged
chore: improve types, migrate griffith-standalone to ts#207ambar merged 5 commits intozhihu:masterfrom
ambar merged 5 commits intozhihu:masterfrom
Conversation
Collaborator
ambar
commented
Sep 13, 2021
ambar
commented
- 最后一个包（griffith-standalone）迁移 TS
- 合并 PlayerContainer/Player，减少重复代码，精简类型定义
- 重新使用 rollup 构建，更快，更容易添加变量控制条件 —— microbundle 不适合 monorepo，因为它需求每个项目下单独使用 tsconfig.json，并且读取其中的值，不能复用
- eslint 更新 overrides，让 js/ts 互不影响
aftdotleo
reviewed
Sep 13, 2021
aftdotleo
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.