Skip to content

Fix TLS record overflow by limiting inner record length to 2^14#18573

Merged
andrewrk merged 1 commit into
ziglang:masterfrom
melonedo:fix-tls-record-overflow
Jan 16, 2024
Merged

Fix TLS record overflow by limiting inner record length to 2^14#18573
andrewrk merged 1 commit into
ziglang:masterfrom
melonedo:fix-tls-record-overflow

Conversation

@melonedo
Copy link
Copy Markdown
Contributor

@melonedo melonedo commented Jan 15, 2024

Per last paragraph of RFC 8446, Section 5.2, the length of the inner content of an encrypted record must not exceed 2^14 + 1, while that of the whole encrypted record must not exceed 2^14 + 256.

Fix #17600 and #15626.

@melonedo melonedo force-pushed the fix-tls-record-overflow branch 2 times, most recently from 94f7c02 to b091a07 Compare January 16, 2024 04:58
Per last paragraph of RFC 8446, Section 5.2, the length of the inner content of an encrypted record must not exceed 2^14 + 1, while that of the whole encrypted record must not exceed 2^14 + 256.
@jedisct1 jedisct1 force-pushed the fix-tls-record-overflow branch from b091a07 to e60c4ee Compare January 16, 2024 09:42
@andrewrk andrewrk merged commit 9b0da5c into ziglang:master Jan 16, 2024
@andrewrk
Copy link
Copy Markdown
Member

Thank you @melonedo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Posting more than 66446 bytes to a TLS endpoint results in panic: integer overflow

2 participants