add an error for stack allocations in naked functions#21082
Merged
andrewrk merged 2 commits intoziglang:masterfrom Aug 16, 2024
Merged
add an error for stack allocations in naked functions#21082andrewrk merged 2 commits intoziglang:masterfrom
andrewrk merged 2 commits intoziglang:masterfrom
Conversation
andrewrk
requested changes
Aug 15, 2024
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
The error message shouldn't mention the stack, only the language rule. Pointing at the type is a bit weird. Pointing at the keyword or name is OK.
|
Will this error also trigger for usage of |
Member
|
A good question that should be answered with a few more lines in the test case. |
i make the assumption that all these added checks will stop us from reaching further sites where `alloc` is emitted
Rexicon226
force-pushed
the
naked-stack
branch
from
204539f to
fb0f4da
Compare
Rexicon226
force-pushed
the
naked-stack
branch
3 times, most recently
from
d0c5b69 to
121c9ce
Compare
Rexicon226
force-pushed
the
naked-stack
branch
from
121c9ce to
8885554
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #72